On 11/9/22 11:41, Asutosh Das wrote:
+/* UFSHC 4.0 compliant HC support this mode, refer param_set_mcq_mode() */ +static bool mcq_mode = true;
Please rename both the variable and the kernel module parameter "mcq_mode" into "use_mcq_mode".
+module_param_cb(mcq_mode, &mcq_mode_ops, &mcq_mode, 0644); +MODULE_PARM_DESC(mcq_mode, "Disable MCQ mode for UFSHCI 4.0 controllers");
The description of this parameter is confusing since it suggests that setting this parameter to 1 disables MCQ mode.
Thanks, Bart.
