On 11/9/22 04:34, Christoph Hellwig wrote:
On Tue, Nov 08, 2022 at 03:33:39PM -0800, Bart Van Assche wrote:
From: Eric Biggers <ebiggers@xxxxxxxxxx>
Modify the UFSHCD core to allow 'struct ufshcd_sg_entry' to be
variable-length. The default is the standard length, but variants can
override ufs_hba::sg_entry_size with a larger value if there are
vendor-specific fields following the standard ones.
There is absolutely nothing 'vendor' in here, it is all implementation
specifc. I have no idea why no touching ufs can grasp this.
Hi Christoph,
I'm not sure how to interpret your reply. Anyway, this patch is required
to use the encryption functionality of the UFS Exynos controller. The
"vendor-specific fields" text in the patch description refers to the
encryption fields since these follow the data buffer when using the
Exynos controller. Although it makes me unhappy that the UFS Exynos
controller is not compliant with the UFS specification, since it is
being used widely I think we need support for this controller in the
upstream kernel.
Thanks,
Bart.
