Re: [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/22 11:03, Asutosh Das wrote:
  int ufshcd_mcq_init(struct ufs_hba *hba)
  {
-	int ret;
+	int ret, i;
+	struct ufs_hw_queue *hwq;

Although this is not a strict rule, most kernel developers these days order declarations from longer to shorter ("reverse Christmas tree").

+	/* The very first HW queue is to serve device command */

is to serve -> serves
command -> commands

Otherwise this patch looks good to me.

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux