Re: [PATCH 4/4] gdth: Isolate driver-global variables using helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 20, 2007 at 10:23:03PM -0400, Jeff Garzik wrote:
>     [SCSI] gdth: Isolate driver-global variables using helpers
>     
>     Sanitizes access to some driver-global variables, in preparation for
>     making them dynamic rather than statically-sized.
>     
>     This equivalent-transform style change blissfully ignores the fact that
>     gdth_ctr_vtab[] is never used (only assigned), and that the driver
>     itself seems to get a bit confused between gdth_ctr_count and
>     gdth_ctr_vcount.  The whole virtual-controller stuff needs reviewing
>     for edge cases.

NACK.  This crap should mostly go away entirely and not beeing isolated.
I have patches for that somewhere deep down in my patchqueue.  I can't
surprise to have them forward ported today, but I'll try.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux