On 10/21/22 02:52, Bart Van Assche wrote: > On 10/19/22 16:23, Damien Le Moal wrote: >> Anyway, while not being a fan of the function call + struct initialization >> all together, this looks correct to me. > > Hi Damien, > > I asked to make this change for scsi_execute() because Mike's patch > series adds an argument to that macro and because I would like to add > another argument to that macro. Adding a member to a struct is much > easier than adding an additional argument to a macro and updating all > callers. I like that the arguments are passed as a struct. This is fine. It is the struct being initialized inside the "( )" for the function call that I am not a fan of. But as said, not a big deal. > > Thanks, > > Bart. -- Damien Le Moal Western Digital Research
