On 17/10/2022 11:45, Niklas Cassel wrote:
On Mon, Oct 17, 2022 at 05:20:31PM +0800, John Garry wrote:
From: Xingui Yang<yangxingui@xxxxxxxxxx>
When an NCQ error occurs, the controller will abnormally complete the I/Os
that are newly delivered to disk, and bit8 in CQ dw3 will be set which
indicates that the SATA disk is in error state. The current processing flow
is to set ts->stat to SAS_OPEN_REJECT and then sas_ata_task_done() will
set FIS stat to ATA_ERR. After analyzing the IO by ata_eh_analyze_tf(),
err_mask will set to AC_ERR_HSM. If media error occurs for four times
within 10 minutes and the chip rejects new I/Os for four times, NCQ will
be disabled due to excessive errors, which is undesirable.
With patch 8/8 in this series, will it still set err_mask to AC_ERR_HSM?
If not, is this patch still needed with patch 8/8?
I spoke to colleague Xingui Yang and he does not think that it is still
required. But I was leaving it in as it still looked like a sensible
change. I suppose I can drop it.
Thanks,
John
