On Thu, 2007-07-19 at 15:06 -0700, Andrew Vasquez wrote: > + dmp_reg = (uint32_t __iomem *)((uint8_t __iomem *)reg + 0xF0); > + WRT_REG_DWORD(dmp_reg, 0xB0100000); > + dmp_reg = (uint32_t __iomem *)((uint8_t __iomem *)reg + 0xFC); > + fw->shadow_reg[1] = htonl(RD_REG_DWORD(dmp_reg)); Repeating this horrible cast over and over again is really eye watering. If you can't simply extend the struct device_reg_24xx as device_reg_25xx or something which seems more logical, what about uint32_t __iomem *mailbox_reg_select = (uint32_t __iomem *)((uint8_t __iomem *)reg + 0xF0); uint32_t __iomem *mailbox_reg_value = (uint32_t __iomem *)((uint8_t __iomem *)reg + 0xFC); ? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
