On 10/3/22 10:53, Mike Christie wrote:
This simplifies sd_spinup_disk so scsi-ml retries errors for it. Note that
we retried specifically on a UA and also if scsi_status_is_good returned
failed which could happen for all check conditions, so in this patch we
don't check for only UAs.
We do not handle the outside loop's retries because we want to sleep
between tried and we don't support that yet.
Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx>
---
drivers/scsi/sd.c | 68 ++++++++++++++++++++++++++---------------------
1 file changed, 37 insertions(+), 31 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a35c089c3097..912cc2623d47 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2064,50 +2064,56 @@ sd_spinup_disk(struct scsi_disk *sdkp)
{
unsigned char cmd[10];
Can the cmd[] declaration be changed into something like the following?
static const u8 cmd[10] = { TEST_UNIT_READY };
Thanks,
Bart.
