On Fri, Jun 29, 2007 at 07:21:26AM -0600, Matthew Wilcox wrote:
> I'm in two minds about printing the 'Device not ready' twice. On the
> one hand, it's redundant information. On the other hand, it helps the
> harried sysadmin with multiple simultaneous disc failures tie the two
> messages together.
>
> So I'm not signing off on this because I think it warrants further discussion.
After three weeks with no discussion, I guess it may as well be applied.
----
scsi: Better error messages when device not ready
Because scsi_print_sense_hdr prefixes with KERN_INFO, the output from
scsi_io_completion looks like:
sd 0:0:0:0: [sdb] Device not ready: <6>: Sense Key : 0x2 [current]
: ASC=0x4 ASCQ=0x3
By using scsi_show_sense_hdr, we can get the much more appealing output:
sd 0:0:0:0: [sdb] Device not ready: Sense Key : 0x2 [current]
sd 0:0:0:0: [sdb] Device not ready: ASC=0x4 ASCQ=0x3
Signed-off-by: Matthew Wilcox <matthew@xxxxxx>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 1f5a07b..d0b8608 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -940,7 +940,10 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
if (!(req->cmd_flags & REQ_QUIET)) {
scmd_printk(KERN_INFO, cmd,
"Device not ready: ");
- scsi_print_sense_hdr("", &sshdr);
+ scsi_show_sense_hdr(&sshdr);
+ scmd_printk(KERN_INFO, cmd,
+ "Device not ready: ");
+ scsi_show_extd_sense(sshdr.asc, sshdr.ascq);
}
scsi_end_request(cmd, 0, this_count, 1);
return;
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
