Re: [PATCH v2 4/6] scsi: pm8001: Use sas_task_find_rq() for tagging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/09/2022 11:20, John Garry wrote:
BTW, I do notice that we still have this global lock in delivery path which should be removed at some stage:
> int mvs_queue_command(struct sas_task *task, gfp_t gfp_flags)
{
     ...

     spin_lock_irqsave(&mvi->lock, flags);
     rc = mvs_task_prep(task, mvi, is_tmf, tmf, &pass);
     ...
     spin_unlock_irqrestore(&mvi->lock, flags);
}


oops... that's mvsas. But pm8001 does still use a big lock (which we should get rid off):

int pm8001_queue_command(struct sas_task *task, gfp_t gfp_flags)
{
	...
	pm8001_dbg(pm8001_ha, IO, "pm8001_task_exec device\n");

	spin_lock_irqsave(&pm8001_ha->lock, flags);


Thanks,
John

That really will affect performance...




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux