From: zhang songyi <zhang.songyi@xxxxxxxxxx>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.
Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: zhang songyi <zhang.songyi@xxxxxxxxxx>
---
drivers/scsi/pmcraid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 836ddc476764..057d6172d643 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3493,7 +3493,7 @@ static ssize_t pmcraid_show_log_level(
struct Scsi_Host *shost = class_to_shost(dev);
struct pmcraid_instance *pinstance =
(struct pmcraid_instance *)shost->hostdata;
- return snprintf(buf, PAGE_SIZE, "%d\n", pinstance->current_log_level);
+ return sysfs_emit(buf, "%d\n", pinstance->current_log_level);
}
/**
@@ -3554,7 +3554,7 @@ static ssize_t pmcraid_show_drv_version(
char *buf
)
{
- return snprintf(buf, PAGE_SIZE, "version: %s\n",
+ return sysfs_emit(buf, "version: %s\n",
PMCRAID_DRIVER_VERSION);
}
@@ -3588,7 +3588,7 @@ static ssize_t pmcraid_show_adapter_id(
pinstance->pdev->devfn;
u32 aen_group = pmcraid_event_family.id;
- return snprintf(buf, PAGE_SIZE,
+ return sysfs_emit(buf,
"adapter id: %d\nminor: %d\naen group: %d\n",
adapter_id, MINOR(pinstance->cdev.dev), aen_group);
}
--
2.25.1
