On Wed, 18 Jul 2007 14:58:18 -0700 Randy Dunlap wrote: > On Wed, 18 Jul 2007 10:33:20 -0700 Randy Dunlap wrote: > > > On Wed, 18 Jul 2007 12:29:24 +0300 Boaz Harrosh wrote: > > > > > Randy Dunlap wrote: > > > > On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: > > > > > > > >> If you could do some testing it is grate. The first 3 patches do not > > > >> need scsi-misc specifically. Any post 2.6.20 tree will do. The last patch > > > >> could be done together with attached patch on any 2.6.22 tree. > > > >> (Apply attached patch anywhere before the last patch (4/4) of the patchset) > > > >> Though I do recommend scsi-misc tree. > > > > > > > > I took 2.6.22, backed out Christoph's aha152x.c patch (using > > > > completion for timeouts), added your 5 patches, and then tested. > > > > Does that sound OK? > > > > > > > Yes what you did is perfect > > > I was not aware of "Christoph's aha152x.c patch" is that in scsi-misc? > > > I'm almost positive I did a git-pull before I sent the patches. > > > Sorry about that. > > > > > > >> Testing: > > > > > > > > I booted/tested 4 times. 2 Oopsen and 2 of > > > > could-never-mount-the-device-due-to-reset-problems. > > > > Log is attached. > > > > > > > > > > > > --- > > > > ~Randy > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > > > Thank you for testing and helping me with this. > > > > > > I found one thing that should definitely trash the Reset > > > and do funny things. But I'm not sure it is it at all. > > > If below does not work, could you pleas do a small bisect > > > of my patches. > > > > > > first patch first, than 2nd, 3rd ,accessors thing, and 4th > > > > Hi, > > > > I don't see the reset problem after applying this patch, but I'm > > still seeing an Oops in datao_run. Log is attached. Looks to me like this driver doesn't handle highmem virtual addresses very well. I expect that it would work OK if CONFIG_HIGHMEM=n or it had a slave_alloc function to limit the memory addresses that it sees (like ppa & imm do). As it is on a machine with HIGHMEM=y, it gets sglist virtual addresses of 0, e.g.: [ 527.416000] (scsi2:4:0) queue: c27331a0; cmd_len=10 pieces=13 size=53248 cmnd=Write(10) 2a 00 00 0c c0 20 00 00 68 00 [ 527.416000] (scsi2:4:0) queue: buffer=sglist=c25ffc68, ptr=ADDR=00000000, this_resid=4096, bufs_resid=12 [ 527.416000] queue segs[0], seg=c25ffc68, page=c2259e18, offset=0x0, virt=00000000 [ 527.416000] queue segs[1], seg=c25ffc78, page=c23c94d8, offset=0x0, virt=00000000 [ 527.416000] queue segs[2], seg=c25ffc88, page=c223c840, offset=0x0, virt=00000000 [ 527.416000] queue segs[3], seg=c25ffc98, page=c2230248, offset=0x0, virt=00000000 [ 527.416000] queue segs[4], seg=c25ffca8, page=c23c65a8, offset=0x0, virt=ff8af000 [ 527.416000] queue segs[5], seg=c25ffcb8, page=c226d210, offset=0x0, virt=ff8fb000 [ 527.416000] queue segs[6], seg=c25ffcc8, page=c2246908, offset=0x0, virt=00000000 [ 527.416000] queue segs[7], seg=c25ffcd8, page=c22467a0, offset=0x0, virt=00000000 [ 527.416000] queue segs[8], seg=c25ffce8, page=c2264de0, offset=0x0, virt=00000000 [ 527.416000] queue segs[9], seg=c25ffcf8, page=c223c8e0, offset=0x0, virt=00000000 [ 527.416000] queue segs[10], seg=c25ffd08, page=c23c8bf0, offset=0x0, virt=00000000 [ 527.416000] queue segs[11], seg=c25ffd18, page=c2231e40, offset=0x0, virt=00000000 [ 527.416000] queue segs[12], seg=c25ffd28, page=c22467c8, offset=0x0, virt=00000000 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
