Re: [PATCH RFC 01/22] scsi: Add helper to prep sense during error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/22/22 10:36, michael.christie@xxxxxxxxxx wrote:
On 9/22/22 11:57 AM, Bart Van Assche wrote:
On 9/22/22 03:06, Mike Christie wrote:
+static enum scsi_disposition scsi_prep_sense(struct scsi_cmnd *scmd,
+                         struct scsi_sense_hdr *sshdr)

How about choosing another name for this function? All other functions with "prep" in their name are called before a command is submitted while this function is called from the completion path.

I'll think of something. scsi_init_sense_processing or scsi_start_sense_processing?

Thanks - I like the second name a bit better than the first :-)

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux