Hi Guenter, On Mon, 19 Sep 2022, 3:01pm, Guenter Roeck wrote: > On Fri, Aug 26, 2022 at 03:25:57AM -0700, Nilesh Javali wrote: > > From: Arun Easi <aeasi@xxxxxxxxxxx> > > > > Older tracing of driver messages was to: > > - log only debug messages to kernel main trace buffer AND > > - log only if extended logging bits corresponding to this > > message is off > > > > This has been modified and extended as follows: > > - Tracing is now controlled via ql2xextended_error_logging_ktrace > > module parameter. Bit usages same as ql2xextended_error_logging. > > - Tracing uses "qla2xxx" trace instance, unless instance creation > > have issues. > > - Tracing is enabled (compile time tunable). > > - All driver messages, include debug and log messages are now traced > > in kernel trace buffer. > > > > Trace messages can be viewed by looking at the qla2xxx instance at: > > /sys/kernel/tracing/instances/qla2xxx/trace > > > > Trace tunable that takes the same bit mask as ql2xextended_error_logging > > is: > > ql2xextended_error_logging_ktrace (default=1) > > > > Suggested-by: Daniel Wagner <dwagner@xxxxxxx> > > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx> > > Signed-off-by: Arun Easi <aeasi@xxxxxxxxxxx> > > Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx> > > I understand this has already been reported early September, but then > the problem disapppeared in next-20220912 and reappeared in next-20220919. > > This patch results in various test build failures. Example: > > Building powerpc:skiroot_defconfig ... failed > -------------- > Error log: > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init': > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: > implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? > > Guenter > Apologies for the troubles this patch has caused. A fix for this is already posted (in trace.h), but is awaiting a final approval from the maintainer: https://lore.kernel.org/linux-scsi/20220907233308.4153-2-aeasi@xxxxxxxxxxx/ Martin, In the interest of time, and with more people running into the build failures, if you want to pick up "Ren Zhijie"'s fix posted earlier today with the fix all contained within the qla2xxx driver, feel free to go ahead (I will NAK my NAK in that case :o ) Regards, -Arun
