On 9/13/22 07:05, John Garry wrote:
On 09/09/2022 00:35, Bart Van Assche wrote:
diff --git a/drivers/scsi/esas2r/esas2r_main.c
b/drivers/scsi/esas2r/esas2r_main.c
index 7a4eadad23d7..fbf7fdb3b52a 100644
--- a/drivers/scsi/esas2r/esas2r_main.c
+++ b/drivers/scsi/esas2r/esas2r_main.c
@@ -248,7 +248,6 @@ static struct scsi_host_template driver_template = {
.sg_tablesize = SG_CHUNK_SIZE,
.cmd_per_lun =
ESAS2R_DEFAULT_CMD_PER_LUN,
- .present = 0,
nit: this really could be a separate change. It's not really strictly
related to introducing scsi_template_proc_dir()
I will move this change into a separate patch.
diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c
index 95aee1ad1383..eeb9261c93f7 100644
--- a/drivers/scsi/scsi_proc.c
+++ b/drivers/scsi/scsi_proc.c
Again, seems it should be a separate change - this is not esas2r code now
In the kernel community it is strongly recommended to introduce new
functions in the same patch that adds a user. Hence the presence of
scsi_proc.c changes in this patch.
+EXPORT_SYMBOL(scsi_template_proc_dir);
Don't we encourage EXPORT_SYMBOL_GPL? The core code seems a mishmash.
I will change this into EXPORT_SYMBOL_GPL().
+#if defined(CONFIG_SCSI_PROC_FS)
+struct proc_dir_entry *
I don't feel too strongly about this, but elsewhere we have extern and I
thought that consistency trumps coding standards.
Should I submit a separate patch that removes superfluous uses of the
'extern' keyword?
Thanks,
Bart.
