On 9/9/22 6:32 AM, Konstantin Shelekhin wrote: >> The patch solves the presence of non-deletable empty default_tg_pt_gp >> in RTPG. >> May be, a global attribute like target/core/alua/hide_emtpy_tpg would >> fit better than an attribute per each port group? >> >> I would always hide the empty default_lu_gp (not configurable) but I am >> afraid that it will be considered as not backward compatible change. 🙁 > A module parameter perhaps? Or a CONFIG definition. For the ceph iscsi project we wanted this same behavior for a while and we had to use distro kernels. There are probably others that need the same thing so a kernel config option wouldn't work for them. Module param or a global attr in target/core/alua like Dimitry mentioned seem fine. If the new variable is set are you guys thinking that core_tpg_add_lun would just not call target_attach_tg_pt_gp? So the variable would be "make_default_tg_pt_gp"?
