On Thu, Aug 11, 2022 at 08:12:06PM -0500, Mike Christie wrote:
> Passthrough users will set the scsi_cmnd->allowed value and were
> expecting up to $allowed retries. The problem is that before:
>
> commit 6aded12b10e0 ("scsi: core: Remove struct scsi_request")
>
> we used to set the retries on the scsi_request then copy them over to
> scsi_cmnd->allowed in scsi_setup_scsi_cmnd. With that patch we now set
> scsi_cmnd->allowed to 0 in scsi_prepare_cmd and overwrite what the
> passthrough user set.
>
> This moves the allowed initialization to after the blk_rq_is_passthrough
> check so it's only done for the non-passthrough path where the ULD
> init_command will normally set an allowed value it prefers.
>
> Fixes: 6aded12b10e0 ("scsi: core: Remove struct scsi_request")
> Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx>
Looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
