On Thu, 2022-08-11 at 11:15 -0500, Mike Christie wrote: > > > > I don't think it's _that_ speficic. (retries < allowed) is the > > default > > case, at least for the first failure. REQ_FAILFAST_DEV has very few > > users except for the device handlers, and NEEDS_RETRY is a rather > > frequently used disposition. > I'm saying it's really specific because we only hit this code > path that is causing issues when scsi_check_sense returns > NEEDS_RETRY. What about the other cases in scsi_decide_disposition() that jump to maybe_retry? > There's 5 in there and one in scsi_dh_alua. 4 of them are UAs. > > Compared to all the sense errors that we check for in the > scsi_execute callers and including all the times they do a retry for > all errors the 5 cases in scsi_check_sense seemed really specific. > > Let me send a patch for this type of design because in the other mail > Christoph was asking for more details. I originally started going > that > route so it won't be too much trouble to do a RFC so we can get an > idea of what it will look like. Looking forward to it. Martin
