On Tue, Aug 09, 2022 at 10:41:52PM -0500, Mike Christie wrote: > scsi_init_command(sdev, cmd); > > + if (!blk_rq_is_passthrough(req)) > + cmd->allowed = 0; > + > cmd->eh_eflags = 0; > - cmd->allowed = 0; While this is correct, I think it makes the function read rather odd. I'd move it down after the: if (blk_rq_is_passthrough(req)) return scsi_setup_scsi_cmnd(sdev, req); and maybe add a comment; /* usually overriden by the ULP */ cmd->allowed = 0;