Hey Daniel,
> On Jul 28, 2022, at 6:47 AM, Daniel Wagner <dwagner@xxxxxxx> wrote:
>
> On Thu, Jul 28, 2022 at 01:50:07PM +0200, Daniel Wagner wrote:
>> Move the both ONLINE state check into qla2x00_update_fcport and call
>> both register port register functions.
>>
>> Currently, qla2x00_reg_remote_port and qla_nvme_register_remote check
>> the state if it is ONLINE. If it not, the state is set to ONLINE and
>> the function is executed.
>>
>> qla2x00_reg_remote_port is called before qla_nvme_register_remote and
>> hence qla_nvme_register_remote will always bail out and never register
>> a nvme remote port.
>>
>> Fixes: 6a45c8e137d4 ("scsi: qla2xxx: Fix disk failure to rediscover")
>> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
>> Cc: Quinn Tran <qutran@xxxxxxxxxxx>
>> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
>> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
>
> I see the offending patch got reverted. FWIW, this patch works for me
> fine.
Do you see issue with reverted patch?
I see no issues with the code change per say, just want to understand if
you were seeing issue with the offending patch reverted as well?
--
Himanshu Madhani Oracle Linux Engineering
