Hello,
On 8/1/2022 9:43 AM, Bart Van Assche wrote:
On 8/1/22 07:30, Peter Wang wrote:
Or, do you think we can direct remove ufshcd_wb_toggle in clock
scaling and only let sysfs to control wb behavior?
I think it's worth asking the people who introduced this feature whether
it can be removed.
Hi Asutosh,
Commit 3d17b9b5ab11 ("scsi: ufs: Add write booster feature support")
introduced the following code in ufshcd_devfreq_scale():
+ /* Enable Write Booster if we have scaled up else disable it */
+ up_write(&hba->clk_scaling_lock);
+ ufshcd_wb_ctrl(hba, scale_up);
+ down_write(&hba->clk_scaling_lock);
Would you mind if the code for enabling/disabling the WriteBooster is
removed again from ufshcd_devfreq_scale() and that a new mechanism is
introduced for controlling the WriteBooster mechanism?
Qualcomm would need the load based toggling of WB during scaling.
What would the new mechanism be for controlling WB mechanism?
Thanks,
Bart.
