Re: [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: j-young.choi@xxxxxxxxxxx, ALIM AKHTAR <alim.akhtar@xxxxxxxxxxx>, "avri.altman@xxxxxxx" <avri.altman@xxxxxxx>, "jejb@xxxxxxxxxxxxx" <jejb@xxxxxxxxxxxxx>, "martin.petersen@xxxxxxxxxx" <martin.petersen@xxxxxxxxxx>, "beanhuo@xxxxxxxxxx" <beanhuo@xxxxxxxxxx>, "adrian.hunter@xxxxxxxxx" <adrian.hunter@xxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 29 Jul 2022 13:22:38 -0700
In-reply-to: <20220729045433epcms2p77ff2cdde6ddffd9ab0b0810ebe84f0e5@epcms2p7>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 7/28/22 21:54, Jinyoung CHOI wrote:

-static inline void ufshcd_wb_config(struct ufs_hba *hba)
+static void ufshcd_wb_set_default_flags(struct ufs_hba *hba)

It is not clear to me why the new name is considered an improvement? Theold name looks better to me. If you want to rename this function anyway,how about ufshcd_configure_wb()?


Thanks,

Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test
  - From: Jinyoung CHOI
- [PATCH v5 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup
  - From: Jinyoung CHOI
- [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name
  - From: Jinyoung CHOI

Prev by Date: Re: [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test
Next by Date: Re: [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute
Previous by thread: [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name
Next by thread: RE:(2) [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]