On 7/26/22 8:50 AM, Finn Thain wrote:
On Mon, 25 Jul 2022, Bart Van Assche wrote:
On 7/25/22 06:15, peter.wang@xxxxxxxxxxxx wrote:
From: Peter Wang <peter.wang@xxxxxxxxxxxx>
Some editor cannot display ‘0’ ‘1’ in correct format.
Change it to '0' '1' for most editor can display.
As far as I know checkpatch accepts non-ASCII UTF-8 characters. Using
this encoding is essential to spell non-English names correctly in
source files.
The only foreign language that's relevant in the context of this
particular comment is C. Writing '0' to indicate a char value would be
fine but this is not a char value.
Quoted and unquoted zeros are used inconsistently in this comment, though
the patch does not address this unfortunately.
I don't think it's feasible nor desirable to eliminate all non-ASCII
UTF-8 from kernel source code files.
That's neither here nor there -- I don't think it's feasible or desirable
to eliminate all bugs from the kernel source code files. One man's bug is
another man's feature e.g. bloat, choice of programming language,
interpretation of license terms.
Maybe this means that it's time to switch to another editor?
It's not hard to find more tooling that is impacted by misplaced unicode.
The security vulnerabilities stemming from the use of Unicode in source
files are telling.
Unicode doesn't help here so it shouldn't have been used here IMO.
Hi Finn,
Thank you for supplementary information.
Thanks.
Peter
