Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

To: Avri Altman <Avri.Altman@xxxxxxx>, Can Guo <quic_cang@xxxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>, "stanley.chu@xxxxxxxxxxxx" <stanley.chu@xxxxxxxxxxxx>, "adrian.hunter@xxxxxxxxx" <adrian.hunter@xxxxxxxxx>, "alim.akhtar@xxxxxxxxxxx" <alim.akhtar@xxxxxxxxxxx>, "beanhuo@xxxxxxxxxx" <beanhuo@xxxxxxxxxx>, "quic_nguyenb@xxxxxxxxxxx" <quic_nguyenb@xxxxxxxxxxx>, "quic_ziqichen@xxxxxxxxxxx" <quic_ziqichen@xxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "kernel-team@xxxxxxxxxxx" <kernel-team@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
From: "Asutosh Das (asd)" <quic_asutoshd@xxxxxxxxxxx>
Date: Fri, 22 Jul 2022 13:14:51 -0700
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Daejun Park <daejun7.park@xxxxxxxxxxx>, Jinyoung Choi <j-young.choi@xxxxxxxxxxx>, Kiwoong Kim <kwmad.kim@xxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <DM6PR04MB6575B4E2707200BDFFEE4A08FC909@DM6PR04MB6575.namprd04.prod.outlook.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3

On 7/22/2022 12:37 PM, Avri Altman wrote:

+
+       /* Manually allocate MCQ resource */

Did you consider to force providing the MCQ configuration?

How about this one?

Sorry missed this comment.
Do you mean to return error if MCQ configuration is undefined?

-asd

Follow-Ups:
- RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Avri Altman

References:
- [PATCH 0/2] UFS Multi-Circular Queue (MCQ)
  - From: Can Guo
- [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Can Guo
- RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Avri Altman
- Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Asutosh Das (asd)
- RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Avri Altman