Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Avri Altman <Avri.Altman@xxxxxxx>, Can Guo <quic_cang@xxxxxxxxxxx>, "stanley.chu@xxxxxxxxxxxx" <stanley.chu@xxxxxxxxxxxx>, "adrian.hunter@xxxxxxxxx" <adrian.hunter@xxxxxxxxx>, "alim.akhtar@xxxxxxxxxxx" <alim.akhtar@xxxxxxxxxxx>, "beanhuo@xxxxxxxxxx" <beanhuo@xxxxxxxxxx>, "quic_asutoshd@xxxxxxxxxxx" <quic_asutoshd@xxxxxxxxxxx>, "quic_nguyenb@xxxxxxxxxxx" <quic_nguyenb@xxxxxxxxxxx>, "quic_ziqichen@xxxxxxxxxxx" <quic_ziqichen@xxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "kernel-team@xxxxxxxxxxx" <kernel-team@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 22 Jul 2022 10:58:24 -0700
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Daejun Park <daejun7.park@xxxxxxxxxxx>, Jinyoung Choi <j-young.choi@xxxxxxxxxxx>, Kiwoong Kim <kwmad.kim@xxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <DM6PR04MB65750EE12401C4F69B352E5CFC909@DM6PR04MB6575.namprd04.prod.outlook.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 7/22/22 00:31, Avri Altman wrote:

+#define UFSHCD_MCQ_IO_QUEUE_OFFSET     1

Maybe add a comment above: "queue 0 is reserved for query commands" or something
That is if the query commands don't use the  legacy doorbell

Is it essential to reserve a queue for device management commands?Wouldn't it be better to have one additional queue for submitting I/Ocommands rather than reserving a queue for device management commands?


Thanks,

Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Can Guo

References:
- [PATCH 0/2] UFS Multi-Circular Queue (MCQ)
  - From: Can Guo
- [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Can Guo
- RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
  - From: Avri Altman

Prev by Date: Re: [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support
Next by Date: Re: [PATCH v1] scsi: ufs: correct ufshcd_shutdown flow
Previous by thread: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Next by thread: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]