On Mon, Jul 16 2007, FUJITA Tomonori wrote:
> From: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Subject: [PATCH 31/33] Fusion: sg chaining support
> Date: Mon, 16 Jul 2007 11:47:45 +0200
>
> > Cc: Eric.Moore@xxxxxxx
> > Signed-off-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
> > ---
> > drivers/message/fusion/mptscsih.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> > index d356173..f087249 100644
> > --- a/drivers/message/fusion/mptscsih.c
> > +++ b/drivers/message/fusion/mptscsih.c
> > @@ -297,7 +297,7 @@ nextSGEset:
> > v2 = sg_dma_address(sg);
> > mptscsih_add_sge(psge, sgflags | thisxfer, v2);
> >
> > - sg++; /* Get next SG element from the OS */
> > + sg = sg_next(sg); /* Get next SG element from the OS */
> > psge += (sizeof(u32) + sizeof(dma_addr_t));
> > sgeOffset += (sizeof(u32) + sizeof(dma_addr_t));
> > sg_done++;
> > @@ -318,7 +318,7 @@ nextSGEset:
> > v2 = sg_dma_address(sg);
> > mptscsih_add_sge(psge, sgflags | thisxfer, v2);
> > /*
> > - sg++;
> > + sg = sg_next(sg);
> > psge += (sizeof(u32) + sizeof(dma_addr_t));
> > */
> > sgeOffset += (sizeof(u32) + sizeof(dma_addr_t));
> > --
>
> We also need this change?
>
> diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> index f087249..a3e6170 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -289,7 +289,7 @@ nextSGEset:
> for (ii=0; ii < (numSgeThisFrame-1); ii++) {
> thisxfer = sg_dma_len(sg);
> if (thisxfer == 0) {
> - sg ++; /* Get next SG element from the OS */
> + sg = sg_next(sg); /* Get next SG element from the OS */
> sg_done++;
> continue;
> }
Indeed we do, thanks for spotting that. Applied.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
