Hi Can, I love your patch! Yet something to improve: [auto build test ERROR on jejb-scsi/for-next] [also build test ERROR on mkp-scsi/for-next next-20220719] [cannot apply to linus/master v5.19-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Can-Guo/UFS-Multi-Circular-Queue-MCQ/20220719-150436 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220720/202207201927.zCPpAzRa-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2b7356bcd24efd2d6b69f04dd9fd010c4256cc7e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Can-Guo/UFS-Multi-Circular-Queue-MCQ/20220719-150436 git checkout 2b7356bcd24efd2d6b69f04dd9fd010c4256cc7e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ufs/core/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/ufs/core/ufs-mcq.c: In function 'ufshcd_mcq_release_resource': >> drivers/ufs/core/ufs-mcq.c:275:25: error: implicit declaration of function 'devm_iounmap'; did you mean 'pci_iounmap'? [-Werror=implicit-function-declaration] 275 | devm_iounmap(hba->dev, res->base); | ^~~~~~~~~~~~ | pci_iounmap cc1: some warnings being treated as errors vim +275 drivers/ufs/core/ufs-mcq.c 265 266 static void ufshcd_mcq_release_resource(struct ufs_hba *hba) 267 { 268 struct ufshcd_res_info_t *res; 269 int i; 270 271 for (i = RES_MCQ; i < RES_MAX; i++) { 272 res = &hba->res[i]; 273 274 if(res->base) { > 275 devm_iounmap(hba->dev, res->base); 276 res->base = NULL; 277 } 278 279 if (res->is_alloc) 280 devm_kfree(hba->dev, res->resource); 281 } 282 } 283 -- 0-DAY CI Kernel Test Service https://01.org/lkp
