On 7/18/22 06:59, Bart Van Assche wrote:
On 7/18/22 03:38, Damien Le Moal wrote:
Even the above code (removing the "sdkp->rc_basis == 0" test) is
borderline in my opinion. The code with the test is per specs, so
correct.
I do not agree that the current code is compliant with the ZBC
specification. My interpretation of the ZBC specification is that the RC
BASIS field influences the meaning of the RETURNED LOGICAL BLOCK ADDRESS
field in the READ CAPACITY response only. The max_lba variable in
sd_zbc_check_capacity() represents the MAXIMUM LBA field from the REPORT
ZONES response. All I found in ZBC-2 about that field is the following:
"The MAXIMUM LBA field contains the LBA of the last logical block on the
logical unit." I haven't found any reference to RC BASIS in the
description of the REPORT ZONES command - neither in ZBC-1 nor in ZBC-2.
Hi Damien,
I want to take the above back. After having taken a closer look at the
READ CAPACITY implementation I think the current implementation of
sd_zbc_check_capacity() is fine.
Thanks,
Bart.
