On 7/14/22 17:17, Liang He wrote:
+static bool phandle_exists(const struct device_node *np, + const char *phandle_name, + int index)
Indentation of the arguments now looks really odd :-(
+{ + struct device_node *parse_np = of_parse_phandle(np, phandle_name, index); + bool ret = false; + + if (parse_np) { + ret = true; + of_node_put(parse_np); + } + + return ret; +}
The 'ret' variable is not necessary. If "return ret" is changed into "return parse_np" then the variable 'ret' can be left out.
Thanks, Bart.