Re: [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Daniil Lunev <dlunev@xxxxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>
Subject: Re: [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 15 Jul 2022 13:08:35 -0700
Cc: Avri Altman <avri.altman@xxxxxxx>, Bean Huo <beanhuo@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20220715224722.1.I22460c4f4a9ccf2c96c3f9bb392b409926d80b2f@changeid>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 7/15/22 05:48, Daniil Lunev wrote:

+#define __INTEL_DSM_SUPPORTED(host, fn) \
+	((fn) < 32 && (fn) >= 0 && ((host)->dsm_fns & (1 << (fn))))


Could this macro have been implemented as a function?

Should '1 << (fn)' perhaps be changed into '1u << (fn)'?

Thanks,

Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM
  - From: Daniil Lunev

Prev by Date: [Bug 215880] Resume process hangs for 5-6 seconds starting sometime in 5.16
Next by Date: Re: [PATCH 3/3] scsi: sd_zbc: Fix handling of RC BASIS
Previous by thread: [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM
Next by thread: [PATCH 0/1] mpi3mr: Fix compilation errors on i386 arch
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux