Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error

Ren Zhijie <renzhijie2@xxxxxxxxxx> · Wed, 13 Jul 2022 09:44:10 +0800

在 2022/7/12 16:27, Arnd Bergmann 写道:
On Mon, Jul 4, 2022 at 4:56 AM Ren Zhijie <renzhijie2@xxxxxxxxxx> wrote:

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index c958279bdd8f..e006c2528a3a 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1427,6 +1427,7 @@ static int ufs_mtk_system_resume(struct device *dev)
  }
  #endif

+#ifdef CONFIG_PM
  static int ufs_mtk_runtime_suspend(struct device *dev)
  {
         struct ufs_hba *hba = dev_get_drvdata(dev);
@@ -1449,6 +1450,7 @@ static int ufs_mtk_runtime_resume(struct device *dev)

         return ufshcd_runtime_resume(dev);
  }
+#endif

  static const struct dev_pm_ops ufs_mtk_pm_ops = {
         SET_SYSTEM_SLEEP_PM_OPS(ufs_mtk_system_suspend,
This change works, but it's not great. It's better to change the
SET_SYSTEM_SLEEP_PM_OPS() to the new SYSTEM_SLEEP_PM_OPS()
that works without the #ifdef.

          Arnd

Hi Arnd,

Thanks for your suggestion.

How does it to fix the implicit-function-declaration error?

Thanks,

Ren Zhijie

.







