On 7/12/22 09:33, Bart Van Assche wrote:
> On 7/11/22 16:19, Damien Le Moal wrote:
>> Note that I think this entire patch could be reduced to just doing this:
>>
>> if (devip->zmodel == BLK_ZONED_HM) {
>> /* Set RC BASIS = 1 */
>> arr[12] |= 0x01 << 4;
>> }
>>
>> No ?
>
> Hi Damien,
>
> The above looks valid to me from the point-of-view of the ZBC-spec.
> However, reducing patch 2/3 to the above would reduce the number of code
> paths in the sd_zbc.c code that can be triggered with the scsi_debug driver.
You lost me... I do not understand what you are trying to say here.
You patch as is repeatedly sets devid->rc_basis to one for every zone in
the zone initialization loop. Not a big problem, but not necessary either.
>
> Thanks,
>
> Bart.
--
Damien Le Moal
Western Digital Research
