Re: [PATCH v1 1/4] m68k - add MVME147 SCSI base address to mvme147hw.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 11.07.2022 um 20:45 schrieb Arnd Bergmann:
On Mon, Jul 11, 2022 at 6:16 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
Am 11.07.2022 um 04:06 schrieb Arnd Bergmann:
On Sat, Jul 9, 2022 at 2:10 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
I think this should be an 'void *__iomem' token, not a plain integer.
Apparently the driver internally uses a 'volatile void *', but some of
the other front-ends are already converted to use __iomem.

I'll pass the base address through a platform data struct in the next
version to address your other concerns. Haven't seen __iomem types used
in the other drivers - two are Zorro devices, and two platform devices
(a3000 and sgiwd93). Found no other wd33c93 drivers...

Right, I noticed this as well. The ideal way to do this would be to change
all of these files to use __iomem tokens consistently, and then use
ioread32be()/iowrite32be() in place of the volatile pointer dereference.

On a second glance, the Amiga drivers _do_ use iomem types (ZTWO_VADDR() does the Right Thing, leaving this driver and SGI.

Changes in wd33c93.c proper (which I read your mail to suggest) would require actual hardware regression testing IMO. Not sure I can do that.

Cheers,

	Michael


Maybe leave that for a follow-up series, you'll probably uncover
more of these issues once you take that step.

       Arnd




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux