Re: [PATCH] scsi: Enlarge log buffer length to 256

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Sorry for the late reply. (Strange! this reply didn't arrive to my mailbox)

On Fri, 24 Jun 2022, Li Zhijian wrote:

> scsi_report_sense() is possble to print messages exceeding 128 bytes: > [ 475.156955] sd 9:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical > > Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx> > --- > drivers/scsi/scsi_logging.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c > index b02af340c2d3..edc3fe8c7e0f 100644 > --- a/drivers/scsi/scsi_logging.c > +++ b/drivers/scsi/scsi_logging.c > @@ -17,7 +17,7 @@ > > static char *scsi_log_reserve_buffer(size_t *len) > { > - *len = 128; > + *len = 256; > return kmalloc(*len, GFP_ATOMIC); > } >
Perhaps it's better to waste fewer words (both kinds). E.g.
Yes, it's an option. if no objection, i will apply your suggestion in 24h later. hahaha :)

Thanks
Zhijian



diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 49ef864df581..e7283bf23db3 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -463,13 +463,11 @@ static void scsi_report_sense(struct scsi_device *sdev, evt_type = SDEV_EVT_LUN_CHANGE_REPORTED;
  			scsi_report_lun_change(sdev);
  			sdev_printk(KERN_WARNING, sdev,
- "Warning! Received an indication that the "   				    "LUN assignments on this target have "
  				    "changed. The Linux SCSI layer does not "
  				    "automatically remap LUN assignments.\n");
  		} else if (sshdr->asc == 0x3f)
  			sdev_printk(KERN_WARNING, sdev,
- "Warning! Received an indication that the "   				    "operating parameters on this target have "
  				    "changed. The Linux SCSI layer does not "
  				    "automatically adjust these parameters.\n");






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux