On Mon, Jun 27, 2022 at 09:29:52PM -0500, Mike Christie wrote:
> +static bool fd_configure_unmap(struct se_device *dev)
> +{
> + struct file *file = FD_DEV(dev)->fd_file;
> + struct inode *inode = file->f_mapping->host;
> +
> + if (S_ISBLK(inode->i_mode)) {
> + return target_configure_unmap_from_queue(&dev->dev_attrib,
> + I_BDEV(inode));
> + } else {
No need for the else here.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
