Oliver Neukum wrote: > Am Donnerstag, 12. Juli 2007 schrieb Boaz Harrosh: >> - use scsi_cmnd data accessors >> - Clean the !use_sg code paths > > This doesn't compile, at least on x86_64, so NAK. > > Regards > Oliver > > CC [M] drivers/usb/image/microtek.o > drivers/usb/image/microtek.c: In function ‘mts_data_done’: > drivers/usb/image/microtek.c:450: warning: implicit declaration of function ‘scsi_set_resid’ > drivers/usb/image/microtek.c: In function ‘mts_command_done’: > drivers/usb/image/microtek.c:494: warning: implicit declaration of function ‘scsi_sg_count’ > drivers/usb/image/microtek.c: In function ‘mts_do_sg’: > drivers/usb/image/microtek.c:517: warning: implicit declaration of function ‘scsi_sglist’ > drivers/usb/image/microtek.c:517: warning: assignment makes pointer from integer without a cast > drivers/usb/image/microtek.c: In function ‘mts_build_transfer_context’: > drivers/usb/image/microtek.c:553: warning: implicit declaration of function ‘scsi_bufflen’ > drivers/usb/image/microtek.c:558: warning: assignment makes pointer from integer without a cast > MODPOST vmlinux > Kernel: arch/x86_64/boot/bzImage is ready (#4) > Building modules, stage 2. > MODPOST 1705 modules > ERROR: "scsi_set_resid" [drivers/usb/image/microtek.ko] undefined! > ERROR: "scsi_sg_count" [drivers/usb/image/microtek.ko] undefined! > ERROR: "scsi_sglist" [drivers/usb/image/microtek.ko] undefined! > ERROR: "scsi_bufflen" [drivers/usb/image/microtek.ko] undefined! > make[1]: *** [__modpost] Fehler 1 > make: *** [modules] Fehler 2 This is over current scsi-2.6-misc git tree, and the infrastructure needed for this is going into the linux 2.6.23 merging window. The proposed changes above are for probably 2.6.24 merge window. It is all a part of a clean sweep of every scsi driver in the tree. Most drivers have already been converted and accepted into current scsi-2.6-misc and are do into the current merge window. The microtek.c driver is sitting in USB land but it is a scsi driver and should be maintained through the scsi-2.6-misc tree? No? Boaz - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
