On Thu, 2007-07-12 at 15:29 +0200, Oliver Neukum wrote: > Am Donnerstag, 12. Juli 2007 schrieb Boaz Harrosh: > > > > - use scsi_cmnd data accessors > > - Clean the !use_sg code paths > > This doesn't compile, at least on x86_64, so NAK. > > Regards > Oliver > > CC [M] drivers/usb/image/microtek.o > drivers/usb/image/microtek.c: In function ‘mts_data_done’: > drivers/usb/image/microtek.c:450: warning: implicit declaration of function ‘scsi_set_resid’ > drivers/usb/image/microtek.c: In function ‘mts_command_done’: > drivers/usb/image/microtek.c:494: warning: implicit declaration of function ‘scsi_sg_count’ > drivers/usb/image/microtek.c: In function ‘mts_do_sg’: > drivers/usb/image/microtek.c:517: warning: implicit declaration of function ‘scsi_sglist’ > drivers/usb/image/microtek.c:517: warning: assignment makes pointer from integer without a cast > drivers/usb/image/microtek.c: In function ‘mts_build_transfer_context’: > drivers/usb/image/microtek.c:553: warning: implicit declaration of function ‘scsi_bufflen’ > drivers/usb/image/microtek.c:558: warning: assignment makes pointer from integer without a cast These would appear to be because you're not building against scsi-misc rather than because of a failure in the patch. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html