Hi Avri, Wolfram-san, > From: Avri Altman, Sent: Wednesday, June 22, 2022 6:47 PM > > > > Hi Avri, all, > > > > > > > > [ 0.449917] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode > > > 0x03 > > > > > for idn 1 failed, index 0, err = 253 > > > > > [ 0.452035] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode > > > 0x03 > > > > > for idn 1 failed, index 0, err = 253 > > > > > [ 0.453859] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode > > > 0x03 > > > > > for idn 1 failed, index 0, err = 253 > > > > > [ 0.453874] ufshcd-renesas e6860000.ufs: ufshcd_query_attr_retry: > > > query > > > > > attribute, idn 1, failed with error 253 after 3 retires > > > > Should be interesting to find out who is trying to read an undefined > > > (reserved) attribute in your system. > > > > > > So, the call trace is: > > > > > > [ 0.455361] Call trace: > > > [ 0.455521] ufshcd_query_attr_retry+0x68/0xb0 > > > [ 0.455808] ufshpb_get_dev_info+0x80/0x110 > > > [ 0.456083] ufshcd_probe_hba+0xce0/0x10d0 > > > [ 0.456349] ufshcd_async_scan+0x34/0x310 > > > [ 0.456609] async_run_entry_fn+0x34/0x130 > > > [ 0.456873] process_one_work+0x1e4/0x434 > > > [ 0.457136] worker_thread+0x174/0x4dc > > > [ 0.457379] kthread+0xdc/0xe0 > > > [ 0.457580] ret_from_fork+0x10/0x20 > > > > > > which leads me to this call in ufshpb_get_dev_info(): > > > > > > 2622 ret = ufshcd_query_attr_retry(hba, > > > UPIU_QUERY_OPCODE_READ_ATTR, > > > 2623 QUERY_ATTR_IDN_MAX_HPB_SINGLE_CMD, 0, 0, > > > &max_single_cmd); > > > > > > And from here on, I miss the UFS experience to debug further. But I > > > will happily provide more information if people give me pointers. > > Ah ok. > > That's cool - HPB is enable on your platform. Thank you for the information. I disabled CONFIG_SCSI_UFS_HPB on my environment. After I enabled the config, it also output the messages. > > For some reason JEDEC didn't merge the HPB amendment into UFS4.0 - and I > > forgot all about that attribute. > And the source of this error is that your device does not support HPB2.0, > Which is fine, because HPB2.0 support was removed a while ago. According to Device Descriptor information of my environment, the UFS device itself seems to support HPB2.0. ----- Device Descriptor [Byte offset 0x1f]: bUFSFeaturesSupport = 0xff <--- so device supports HPB ... Device Descriptor [Byte offset 0x40]: wHPBVersion = 0x200 Device Descriptor [Byte offset 0x42]: bHPBControl = 0x1 ----- Anyway, the UFS driver seems to work correctly, IIUC. Best regards, Yoshihiro Shimoda > Thanks, > Avri > > > > > Thanks, > > Avri > > > > > > > > All the best, > > > > > > Wolfram
