On 6/20/22 13:26, Changyuan Lyu wrote:
Traces like scsi_dispatch_cmd_start and scsi_dispatch_cmd_done are
^^^^^^
Aren't these called "trace events" instead of "traces"?
useful for tracking a command thoughout its lifetime. But for some ATA
^^^^^^^^^
throughout?
passthrough commands, the information printed in current logs are not
^^^
is?
enough to identify and match them. For example, if two threads send
SMART cmd to the same disk at the same time, their trace logs may
look the same, which makes it hard to match scsi_dispatch_cmd_done and
scsi_dispatch_cmd_start. Printing tags can help us solve the problem.
Further, if a command failed for some reason and then retried, its
^^^^^^^
is retried?
driver_tag will change. So scheduler_tag is also included such that we
can track the retries of a command.
Despite the above comments, thanks for the detailed and very informative
patch description.
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
