On Sun, Jun 05, 2022 at 11:42:11AM +0200, Hannes Reinecke wrote: > Well ... we tried to find a generic error for reservation failure, as we > thought that reservation failure was too SCSI specific. > And we wanted the error to describe what the resulting handling should be, > not what the cause was. Hence we ended up with BLK_STS_NEXUS. > > But turns out that our initial assumption wasn't valid, and that > reservations are a general concept. So by all means, rename BLK_STS_NEXUS > to BLK_STS_RSV_CONFLICT to make it clear what this error is about. I think think this is a good ida, but we'll need to involve the s390 dasd folks. Maybe do this as a separate prep patch? While thinking about DASD I think it would benefit from returning the blk_status_t from ->free_cp insted of the hand crafted conversion as well.