On 6/19/22 11:26 AM, michael.christie@xxxxxxxxxx wrote: > On 6/19/22 1:25 AM, Christoph Hellwig wrote: >> On Thu, Jun 16, 2022 at 10:04:37PM -0500, Mike Christie wrote: >>> If NDOB is set we don't have a buffer. We will then crash when trying to >>> access the t_data_sg. This has us allocate a page to use for the data >>> buffer that gets passed to vfs_iter_write. >> >> But only due to the last patch, so this should be reordered before >> that. > > I didn't get that part. You can hit this bug with what is upstream right > now. You don't need patch 4. > I see you meant the patch before this one :) Without patch 1, you still hit the crash. In the current code, we print error, call the execute_cmd callout, then for file and iblock crash because there is no sg and we assume there always will be one.
