On 6/12/22 8:43 PM, Yang Li wrote:
> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
This was just added in Martin's 5.20 tree in:
a75fcb0912a549c6c1da8395f33271ce06e84acd
scsi: target: iscsi: Extract auth functions
Do we need a Fixes or should the original patch be fixed?
Patch looks ok to me, so if we just add it:
Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>
> ---
> drivers/target/iscsi/iscsi_target_nego.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
> index 9ce35a59962b..fb93a1173954 100644
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)
> */
> se_nacl = conn->sess->se_sess->se_node_acl;
> if (!se_nacl) {
> - pr_debug("Unknown ACL %s is trying to connect\n",
> - se_nacl->initiatorname);
> + pr_debug("Unknown ACL is trying to connect\n");
> return true;
> }
>
