Re: [PATCH] scsi: iscsi: start endpoint ID allocation from 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/12/22 12:04 PM, Mike Christie wrote:
> On 6/12/22 7:19 AM, Varun Prakash wrote:
>> ktransport_ep_connect() (defined in open-iscsi/usr/netlink.c)
>> returns -EIO if endpoint ID is 0.
>>
>> int
>> ktransport_ep_connect(iscsi_conn_t *conn, int non_blocking)
>> {
>> 	...
>> 	rc = __kipc_call(iov, 2);
>> 	if (rc < 0)
>> 		return rc;
>>
>> 	if (!ev->r.ep_connect_ret.handle)
>> 		return -EIO;
>>
>> 	conn->transport_ep_handle = ev->r.ep_connect_ret.handle;
>> 	...
>> }
>>
>> Fixes: 3c6ae371b8a1 ("scsi: iscsi: Release endpoint ID when its freed")
>> Signed-off-by: Varun Prakash <varun@xxxxxxxxxxx>
> 
> Thanks.
> 
> Ccing Nilesh because qedi was hitting this. I had just sent him a patch for
> this with some other patches.
> 
> Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>

Martin, Ignore my review-by. We are going to go with Sergey's patch:

[PATCH] scsi: iscsi: Exclude zero from the endpoint ID range



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux