On 2022-05-30 16:15:07 [-0700], Davidlohr Bueso wrote: > Tasklets have long been deprecated as being too heavy on the system > by running in irq context - and this is not a performance critical > path. If a higher priority process wants to run, it must wait for > the tasklet to finish before doing so. A more suitable equivalent > is to converted to threaded irq instead and run in regular task > context. The convert looks okay. This driver even disables the interrupt source before scheduling the tasklet :) However the whole routine (sci_controller_completion_handler()) runs with disabled interrupt so it makes no sense to use tasklets for completion or threaded interrupts… > Cc: Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx> > Signed-off-by: Davidlohr Bueso <dave@xxxxxxxxxxxx> Sebastian
