On 06/01, Bart Van Assche wrote: > On 5/31/22 22:24, Adrian Hunter wrote: > > On 31/05/22 23:10, Jaegeuk Kim wrote: > > > + /* > > > + * This quirk disables FUA support. > > > + */ > > > + UFSHCD_QUIRK_BROKEN_FUA = 1 << 17, > > > > Wouldn't it be more appropriate to make it a UFS_DEVICE_QUIRK_ > > since it presumably depends on the UFS device not the host controller? > > > > Also, as already commented by others, there needs to be a user of > > the quirk > > Another possibility is to use the generic SCSI blacklist mechanism. See also > the scsi_static_device_list array. See also /proc/scsi/device_info. From > scsi_devinfo.c: > > /* > * proc_scsi_dev_info_write - allow additions to scsi_dev_info_list via > * /proc. > * > * Description: Adds a black/white list entry for vendor and model with > * an integer value of flag to the scsi device info list. > * To use, echo "vendor:model:flag" > /proc/scsi/device_info > */ Good to know. Thank you, Bart. > > Thanks, > > Bart.
