On Wed, Jun 01, 2022 at 03:25:43PM +0900, Damien Le Moal wrote: > If sd_probe() sees an early error before sdkp->device is initialized, > sd_zbc_release_disk() is called. This causes a NULL pointer dereference > when sd_is_zoned() is called inside that function. Avoid this by > removing the call to sd_zbc_release_disk() in sd_probe() error path. > > This chnage is safe and does not result in zone information memory > leakage because the zone information for a zoned disk is allocated only > when sd_revalidate_disk() is called, at which point sdkp->disk_dev is > fully set, resulting in sd_disk_release() being called when needed to > cleanup a disk zone information using sd_zbc_release_disk(). Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
