Smatch complains that the if (flag_res) is not required: drivers/ufs/core/ufshpb.c:2306 ufshpb_check_hpb_reset_query() warn: duplicate check 'flag_res' (previous on line 2301) Re-write the "if (flag_res)" checking to be more clear. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/ufs/core/ufshpb.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c index fb122eaed28b..95b501b824df 100644 --- a/drivers/ufs/core/ufshpb.c +++ b/drivers/ufs/core/ufshpb.c @@ -2299,17 +2299,15 @@ static bool ufshpb_check_hpb_reset_query(struct ufs_hba *hba) } if (!flag_res) - goto out; + return false; usleep_range(1000, 1100); } - if (flag_res) { - dev_err(hba->dev, - "%s fHpbReset was not cleared by the device\n", - __func__); - } -out: - return flag_res; + + dev_err(hba->dev, + "%s fHpbReset was not cleared by the device\n", + __func__); + return true; } /** -- 2.35.1