On Fri, 2007-07-06 at 00:02 +0100, Al Viro wrote: > On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote: > > Since gendisk will now become part of struct scsi_device, we don't need > > to store this value in any private data structs where they already store > > scsi_device. This series cleans up a few drivers which did this. > > What the hell? gendisks are *NOT* supposed to be embedded into other > data structures, you'll screw up the lifetime rules for them. Don't panic .. they're not ... we have a pointer to the gendisk in our SCSI structures (properly refcounted). The reason is historical and actually goes back to 2002 when we first got rid of the static arrays of structures we used to keep around. Doug ... don't think 'disk' when you see 'gendisk' just think of it as a useful infrastructure library. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
