On 5/24/22 07:25, Christoph Hellwig wrote:
On Mon, May 02, 2022 at 08:09:17AM -0700, Brian Bunker wrote:
case SCSI_ACCESS_STATE_ACTIVE:
case SCSI_ACCESS_STATE_LBA:
- return BLK_STS_OK;
case SCSI_ACCESS_STATE_TRANSITIONING:
- return BLK_STS_AGAIN;
+ return BLK_STS_OK;
As there is a lot of discussion on BLK_STS_AGAIN in the thread:
Independent of the actual outcome here, BLK_STS_AGAIN is fundamentally
the wrong thing to return here. BLK_STS_AGAIN must only be returned
for REQ_NOWAIT requests that would have to block.
Guess we should document that.
It wasn't clear to me that this is a requirement.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman