On 5/19/22 07:08, Christoph Hellwig wrote:
On Thu, May 19, 2022 at 04:00:21PM +0200, Hannes Reinecke wrote:Provide stubs for blkcg_set_fc_appid() and blkcg_get_fc_appid() to allow for compilation with cgroups disabled. Fixes: db05628435aa ("blk-cgroup: move blkcg_{get,set}_fc_appid out of line") Signed-off-by: Hannes Reinecke <hare@xxxxxxx>No, it does not fix that commit, which is perfectly fine. It fixes the recently added second caller of blkcg_get_fc_appid, and James has just resent a new version of that which fixes this properly.
Really? blk-cgroup.h provides the function declaration blkcg_get_fc_appid() unconditionally, but the implementation for blkcg_get_fc_appid() depends on CONFIG_CGROUP. Neither of which is changed by James patchset. And besides, the first version is already merged. Am I missing something? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
